d3d [1]: Remove AddRef from IWineD3DDevice_GetVertexDeclaration.

H. Verbeet hverbeet at gmail.com
Mon Nov 27 17:51:54 CST 2006

On 28/11/06, Markus Amsler <markus.amsler at oribi.org> wrote:
> The following patches remove refcounting in wined3d Getters. The
> Setters/Creaters refcounting can't be removed right now, because of the
> way implicit surfaces are currently handled.
> The idea is to simplify the d3dx<->wined3d refcount relation. Ideally
> every wined3d object gets created with refcount=1, never AddRef'ed and
> destroyed with the first Release call. Rob mentioned this violates COM
> rules, but wined3d is wine internal.
> The GetParent patch doesn't remove wined3d refcounting, it seperates
> d3dx and wined3d refcounting (Which was the reason I started to remove
> AddRefs).
> ---
I think this is a bad idea, if only for consistency with other COM
objects. I don't think wined3d being wine internal is a very good
reason to violate COM rules. IMO if we're going to use COM we should
stick to its rules. Also see my other mail.

More information about the wine-patches mailing list