Make the test for GetClassName called on a small buffer pass
Dmitry Timoshkov
dmitry at codeweavers.com
Mon Oct 23 05:06:59 CDT 2006
Hello,
please apply this patch on top of Mike's GetClassName test.
Changelog:
Make the test for GetClassName called on a small buffer pass.
diff -up cvs/hq/wine/dlls/user/class.c wine/dlls/user/class.c
--- cvs/hq/wine/dlls/user/class.c 2006-10-04 16:28:21.000000000 +0900
+++ wine/dlls/user/class.c 2006-10-23 18:09:07.000000000 +0900
@@ -63,6 +63,7 @@ typedef struct tagCLASS
static struct list class_list = LIST_INIT( class_list );
#define CLASS_OTHER_PROCESS ((CLASS *)1)
+#define MAX_ATOM_LEN 255 /* from dlls/kernel32/atom.c */
/***********************************************************************
* get_class_ptr
@@ -956,9 +957,20 @@ DWORD WINAPI SetClassLongA( HWND hwnd, I
*/
INT WINAPI GetClassNameA( HWND hwnd, LPSTR buffer, INT count )
{
- INT ret = GlobalGetAtomNameA( GetClassLongA( hwnd, GCW_ATOM ), buffer, count );
+ char tmpbuf[MAX_ATOM_LEN + 1];
+ INT ret;
- TRACE("%p %s %x\n",hwnd, debugstr_a(buffer), count);
+ TRACE("%p %p %d\n", hwnd, buffer, count);
+
+ if (count <= 0) return 0;
+
+ ret = GlobalGetAtomNameA( GetClassLongW( hwnd, GCW_ATOM ), tmpbuf, MAX_ATOM_LEN + 1 );
+ if (ret)
+ {
+ ret = min(count - 1, ret);
+ memcpy(buffer, tmpbuf, ret);
+ buffer[ret] = 0;
+ }
return ret;
}
@@ -968,9 +980,20 @@ INT WINAPI GetClassNameA( HWND hwnd, LPS
*/
INT WINAPI GetClassNameW( HWND hwnd, LPWSTR buffer, INT count )
{
- INT ret = GlobalGetAtomNameW( GetClassLongW( hwnd, GCW_ATOM ), buffer, count );
+ WCHAR tmpbuf[MAX_ATOM_LEN + 1];
+ INT ret;
- TRACE("%p %s %x\n",hwnd, debugstr_w(buffer), count);
+ TRACE("%p %p %d\n", hwnd, buffer, count);
+
+ if (count <= 0) return 0;
+
+ ret = GlobalGetAtomNameW( GetClassLongW( hwnd, GCW_ATOM ), tmpbuf, MAX_ATOM_LEN + 1 );
+ if (ret)
+ {
+ ret = min(count - 1, ret);
+ memcpy(buffer, tmpbuf, ret * sizeof(WCHAR));
+ buffer[ret] = 0;
+ }
return ret;
}
diff -up cvs/hq/wine/dlls/user/tests/class.c wine/dlls/user/tests/class.c
--- cvs/hq/wine/dlls/user/tests/class.c 2006-10-16 12:27:18.000000000 +0900
+++ wine/dlls/user/tests/class.c 2006-10-23 18:15:19.000000000 +0900
@@ -414,8 +414,8 @@ static void test_instances(void)
DestroyWindow( hwnd2 );
r = GetClassName( hwnd, buffer, 4 );
- todo_wine ok( r == 3, "return wrong\n");
- ok( !strcmp( buffer, "__t"), "name wrong\n");
+ ok( r == 3, "expected 3, got %d\n", r );
+ ok( !strcmp( buffer, "__t"), "name wrong: %s\n", buffer );
ok( UnregisterClassA( name, kernel32 ), "Unregister failed for kernel32\n" );
More information about the wine-patches
mailing list