widl [3/7]: Replace a #if by if for better compiler checking

Dan Hipschman dsh at linux.ucla.edu
Wed Sep 13 18:31:47 CDT 2006


The use of parameter "n" is hidden by a #ifdef.  The macro isn't defined
anywhere else, and this looks like a feature the user might want to
enable in the future, so replace it with runtime checking.  Eliminates
a warning about an unused paramter.

ChangeLog:
* Replace #if by if so the compiler can see the code inside.
---
 tools/widl/utils.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/tools/widl/utils.c b/tools/widl/utils.c
index 98a66dd..efa88c2 100644
--- a/tools/widl/utils.c
+++ b/tools/widl/utils.c
@@ -34,10 +34,9 @@ #include "widl.h"
 #include "utils.h"
 #include "parser.h"
 
-/* #define WANT_NEAR_INDICATION */
+int want_near_indication = 0;
 
-#ifdef WANT_NEAR_INDICATION
-void make_print(char *str)
+static void make_print(char *str)
 {
 	while(*str)
 	{
@@ -46,13 +45,13 @@ void make_print(char *str)
 		str++;
 	}
 }
-#endif
 
 static void generic_msg(const char *s, const char *t, const char *n, va_list ap)
 {
 	fprintf(stderr, "%s:%d: %s: ", input_name ? input_name : "stdin", line_number, t);
 	vfprintf(stderr, s, ap);
-#ifdef WANT_NEAR_INDICATION
+
+        if (want_near_indication)
 	{
 		char *cpy;
 		if(n)
@@ -63,7 +62,7 @@ #ifdef WANT_NEAR_INDICATION
 			free(cpy);
 		}
 	}
-#endif
+
 	fprintf(stderr, "\n");
 }
 



More information about the wine-patches mailing list