Only perform the screen resolution changing tests in interactive mode.

Francois Gouget fgouget at
Fri Sep 29 06:03:40 CDT 2006

This test is the reason why I have not been running the Wine conformance 
tests for the past year:
 * In my almost stock xorg.conf file, I have 6 different resolutions, 6 
different color depths, and with all that it causes this test to spend 
more than 30 minutes changing screen resolutions. This means my 21 inch 
CRT monitors clicks and resyncs for half an hour and that's just no 
 * IMHO, conformance tests should not be too disruptive. That was mostly 
true for a while, though now we have quite a few tests that pop up 
focused windows :-/
 * Finally the test shows some test screen in each resolution, but if no 
one's watching there's not much point.

So I think it is more reasonable to only run this test in interactive 
mode when someone can actively monitor it, and actually check that each 
test screen is displayed properly.

 dlls/ddraw/tests/ddrawmodes.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/dlls/ddraw/tests/ddrawmodes.c b/dlls/ddraw/tests/ddrawmodes.c
index fd00bb6..5020bec 100644
--- a/dlls/ddraw/tests/ddrawmodes.c
+++ b/dlls/ddraw/tests/ddrawmodes.c
@@ -1,6 +1,13 @@
  * Unit tests for ddraw functions
+ *
+ * Part of this test involves changing the screen resolution. But this is
+ * really disrupting if the user is doing something else and is not very nice
+ * to CRT screens. Plus, ideally it needs someone watching it to check that
+ * each mode displays correctly.
+ * So this is only done if the test is being run in interactive mode.
+ *
  * Copyright (C) 2003 Sami Aario
  * This library is free software; you can redistribute it and/or
@@ -342,7 +349,8 @@ START_TEST(ddrawmodes)
     if (!createdirectdraw())
-    testdisplaymodes();
+    if (winetest_interactive)
+        testdisplaymodes();

More information about the wine-patches mailing list