shell32/tests: On Windows 98 FindExecutable() does not '\0' terminate the returned command which caused many tests to fail.

Francois Gouget fgouget at codeweavers.com
Mon Apr 2 12:32:16 CDT 2007


--- 

This is a pretty big Windows 98 (First Edition, shell32 4.72.3110.6) bug 
so I'm a bit surprised. It would be nice if others could confirm, for 
instance by changing the '\0' to a '\1' and running the test on their 
Windows 98 system.

 dlls/shell32/tests/shlexec.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c
index 37d96ee..b2a158a 100644
--- a/dlls/shell32/tests/shlexec.c
+++ b/dlls/shell32/tests/shlexec.c
@@ -759,6 +759,8 @@ static void test_find_executable(void)
                 c++;
             }
         }
+        /* Win98 does not '\0'-terminate command! */
+        memset(command, '\0', sizeof(command));
         rc=(int)FindExecutableA(filename, NULL, command);
         if (rc > 32)
             rc=33;
-- 
1.4.4.4




More information about the wine-patches mailing list