[PATCH 2/3] urlmon: Call IBindStatusCallback_OnStopBinding only if this actually is the last ReportData.

Misha Koshelev mk144210 at bcm.edu
Thu Aug 2 20:45:17 CDT 2007

This was actually the very first way I came up with of solving the problem of OnStopBinding never
getting called if the http tests are unrolled from the hack. It was actually pretty much necessary to
get them to pass at all when the non-native fill_stream_buffer was still done on every call to ReportData,
as the last notification would get dropped completely because fill_stream_buffer would get to the end
of the data. This is still necessary now when the client's OnDataAvailable results in a call to 
ProtocolStream_Read() and ends up reading all the data; upon return hres is now actually S_FALSE,
OnStopBinding is called, and an ENDDOWNLOADDATA is dropped.

Jacek, in the version of the url.c tests that you sent me, this fixes the following error:
url.c:229: Test failed: expected OnProgress_ENDDOWNLOADDATA
in the emulated http test.
 dlls/urlmon/binding.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0644d34e07cc0ed4a56ec4bfaf1c95639e013922.diff
Type: text/x-patch
Size: 980 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070802/730706ff/0644d34e07cc0ed4a56ec4bfaf1c95639e013922-0001.bin

More information about the wine-patches mailing list