crypt32(3/5): Validate parameters better in CryptDecodeObject

Juan Lang juan.lang at gmail.com
Fri Aug 10 16:38:38 CDT 2007


--Juan
-------------- next part --------------
From 0a607b0118721fb5c3a82f906da785032dac4839 Mon Sep 17 00:00:00 2001
From: Juan Lang <juan.lang at gmail.com>
Date: Fri, 10 Aug 2007 11:20:24 -0700
Subject: [PATCH] Validate parameters better in CryptDecodeObject
---
 dlls/crypt32/decode.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c
index c6f7305..7c50b27 100644
--- a/dlls/crypt32/decode.c
+++ b/dlls/crypt32/decode.c
@@ -4138,6 +4138,16 @@ BOOL WINAPI CryptDecodeObject(DWORD dwCe
         SetLastError(ERROR_INVALID_PARAMETER);
         return FALSE;
     }
+    if (!cbEncoded)
+    {
+        SetLastError(CRYPT_E_ASN1_EOD);
+        return FALSE;
+    }
+    if (cbEncoded > MAX_ENCODED_LEN)
+    {
+        SetLastError(CRYPT_E_ASN1_LARGE);
+        return FALSE;
+    }
 
     if (!(pCryptDecodeObjectEx = CRYPT_GetBuiltinDecoder(dwCertEncodingType,
      lpszStructType)))
-- 
1.4.1


More information about the wine-patches mailing list