crypt32(4/17): Properly reference count certificate contexts referenced by a chain

[Juan Lang]

With patch.
--Juan
-------------- next part --------------
From 210cd57d20312ddfe327c14bc6d8b7fb3569e11b Mon Sep 17 00:00:00 2001
From: Juan Lang <juan.lang at gmail.com>
Date: Thu, 30 Aug 2007 17:50:23 -0700
Subject: [PATCH] Properly reference count certificate contexts referenced by a chain
---
 dlls/crypt32/chain.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/dlls/crypt32/chain.c b/dlls/crypt32/chain.c
index f1711ac..6584085 100644
--- a/dlls/crypt32/chain.c
+++ b/dlls/crypt32/chain.c
@@ -250,7 +250,7 @@ static BOOL CRYPT_AddCertToSimpleChain(P
         {
             memset(element, 0, sizeof(CERT_CHAIN_ELEMENT));
             element->cbSize = sizeof(CERT_CHAIN_ELEMENT);
-            element->pCertContext = cert;
+            element->pCertContext = CertDuplicateCertificateContext(cert);
             if (dwFlags & CERT_STORE_REVOCATION_FLAG &&
              !(dwFlags & CERT_STORE_NO_CRL_FLAG))
                 element->TrustStatus.dwErrorStatus |= CERT_TRUST_IS_REVOKED;
@@ -288,12 +288,18 @@ static BOOL CRYPT_AddCertToSimpleChain(P
     return ret;
 }
 
+static void CRYPT_FreeChainElement(PCERT_CHAIN_ELEMENT element)
+{
+    CertFreeCertificateContext(element->pCertContext);
+    CryptMemFree(element);
+}
+
 static void CRYPT_FreeSimpleChain(PCERT_SIMPLE_CHAIN chain)
 {
     DWORD i;
 
     for (i = 0; i < chain->cElement; i++)
-        CryptMemFree(chain->rgpElement[i]);
+        CRYPT_FreeChainElement(chain->rgpElement[i]);
     CryptMemFree(chain->rgpElement);
     CryptMemFree(chain);
 }
-- 
1.4.1