d3dx8 [2/2]: add basic functions for MatrixStack

Stefan Dösinger stefandoesinger at gmx.at
Wed Dec 5 13:50:59 CST 2007

Am Mittwoch, 5. Dezember 2007 18:13:30 schrieb David.Adam at math.cnrs.fr:
> This is my first attempt with ICOM objects. So, all the advices are
> welcome.
A few suggestions:

+HRESULT WINAPI ID3DXMatrixStackImpl_QueryInterface(ID3DXMatrixStack *iface, 
REFIID riid, void **ppvObject)
+ ...
+     IClassFactory_AddRef(iface);
It is better to use ID3DXMatrixStack_AddRef(iface) here. It is essentially the 
same, but it looks more consistent

The AddRef() and Release() methods should have a TRACE which write either the 
new or old refcount, otherwise tracking refcounting bugs is hell.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071205/ae34fe2e/attachment.pgp 

More information about the wine-patches mailing list