[PATCH] return after get_volume_label

Marcus Meissner marcus at jet.franken.de
Sat Dec 8 05:14:35 CST 2007


get_volume_label already did the stuff necessary, and
the later code would be confused by label_len uninitialized.

spotted by Coverity.

Ciao, Marcus
---
 dlls/kernel32/volume.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c
index 655fda1..13f8da8 100644
--- a/dlls/kernel32/volume.c
+++ b/dlls/kernel32/volume.c
@@ -400,7 +400,7 @@ static void VOLUME_GetSuperblockLabel( const WCHAR *device, enum fs_type type, c
         break;
     case FS_PLACEHOLDER:
         get_filesystem_label( device, label, len );
-        break;
+	return;
     case FS_FAT1216:
         label_ptr = superblock + 0x2b;
         label_len = 11;
-- 
1.5.2.4



More information about the wine-patches mailing list