USER32: fix regression in DlgDirList caused by modified LB_DIR return behavior, with tests
Alex Villacís Lasso
a_villacis at palosanto.com
Wed Dec 19 09:57:18 CST 2007
Recent fixes to LB_DIR behavior for returned value caused a regression
in the DlgDirList[A|W] function. The fix for LB_DIR aimed to comply to
the documented and tested behavior that it should return the last
inserted index. Since the listbox indexes are 0-based, this implies that
in the case that LB_DIR inserts nothing, it should return -1.
Unfortunately, DlgDirList[A|W] took this -1 as a fatal error and stops
filling entries, causing the regression. This patch fixes the regression
and adds tests showing that the LB_DIR behavior is actually correct, and
also tests DlgDirList for the fixed behavior.
Fixes bug 10809.
* DlgDirList should not stop filling listbox if one category does not
return any files in LB_DIR
* Tests showing that LB_DIR behavior is already correct for wildcard
that does not match any files.
* Tests showing DlgDirList behavior for wildcard that does not match any
files, including fixed behavior
perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13686 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071219/e9ed97e6/attachment.bin
More information about the wine-patches