msi: Revert commit 96e4320feb22b3a2c9564de100c09990622edb59

Dmitry Timoshkov dmitry at
Thu Dec 20 02:23:39 CST 2007


I have no idea what Mikolaj tried to fix with this patch but
1. it breaks at least 2 msi installers (msxml3 and visio2003), they start
to display a brokenly looking group box when they shouldn't
2. spy++ under XP shows that in 2 above cases BS_OWNERDRAW is the style
native msi uses for as a parent for a radio buttons group

    msi: Revert commit 96e4320feb22b3a2c9564de100c09990622edb59
 dlls/msi/dialog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index ccb6acc..29f0688 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -1756,7 +1756,7 @@ static UINT msi_dialog_radiogroup_control( msi_dialog *dialog, MSIRECORD *rec )
     TRACE("%p %p %s\n", dialog, rec, debugstr_w( prop ));
     /* Create parent group box to hold radio buttons */
-    control = msi_dialog_add_control( dialog, rec, szButton, BS_GROUPBOX|WS_GROUP );
+    control = msi_dialog_add_control( dialog, rec, szButton, BS_OWNERDRAW|WS_GROUP );
     if( !control )
         return ERROR_FUNCTION_FAILED;

More information about the wine-patches mailing list