[PATCH] msi: Fix memory leak (found by Smatch)

Rico Schüller kgbricola at web.de
Sun Dec 30 18:04:56 CST 2007


---
 dlls/msi/dialog.c |    4 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index 4417d4b..543b443 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -2267,8 +2267,11 @@ static UINT msi_dialog_list_box( msi_dialog *dialog, MSIRECORD *rec )
         style |= LBS_SORT;
 
     control = msi_dialog_add_control( dialog, rec, WC_LISTBOXW, style );
-    if (!control)
+    if (!control)
+    {
+        msi_free(info);
         return ERROR_FUNCTION_FAILED;
+    }
 
     control->handler = msi_dialog_listbox_handler;
 
-- 
1.5.3.3


--------------010404030201050409090409
Content-Type: text/x-diff;
 name="0005-msi-Fix-memory-leak-found-by-Smatch.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="0005-msi-Fix-memory-leak-found-by-Smatch.patch"



More information about the wine-patches mailing list