[PATCH] CID493: check for NULL return

Marcus Meissner meissner at suse.de
Thu Feb 1 09:31:48 CST 2007


Hi,

spotted by coverity. get_attrp might return NULL (if uuid attribute
is missing), so check for it.

Ciao, Marcus
---
 tools/widl/client.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/tools/widl/client.c b/tools/widl/client.c
index 5fcffeb..3e0ff84 100644
--- a/tools/widl/client.c
+++ b/tools/widl/client.c
@@ -331,6 +331,10 @@ static void write_clientinterfacedecl(ty
     unsigned long ver = get_attrv(iface->attrs, ATTR_VERSION);
     const UUID *uuid = get_attrp(iface->attrs, ATTR_UUID);
 
+    if (!uuid) {
+    	error("uuid attribute missing!\n");
+	return;
+    }
     print_client("static const RPC_CLIENT_INTERFACE %s___RpcClientInterface =\n", iface->name );
     print_client("{\n");
     indent++;
-- 
1.4.3.4



More information about the wine-patches mailing list