[1/4] wined3d: Fix WINED3DPRESENT_PARAMETERS and use it instead of D3DPRESENT_PARAMETERS

H. Verbeet hverbeet at gmail.com
Thu Feb 15 17:00:15 CST 2007

On 15/02/07, H. Verbeet <hverbeet at gmail.com> wrote:
> WINED3DPRESENT_PARAMETERS is currently a structure of pointers to the
> actual values we care about. It's probably done like this because for
> most functions that take WINED3DPRESENT_PARAMETERS as parameter it's
> an inout parameter, and the structure is different between d3d8 and
> d3d9. For example, CreateDevice() will write the correct width and
> height if 0 is passed for them and "Windowed" is true. It doesn't make
> the code any nicer to read though, and in the places it's used
> performance is hardly a reason to keep it this way either. But since
> WINED3DPRESENT_PARAMETERS only contains pointers,
> IWineD3DSwapChainImpl uses D3DPRESENT_PARAMETERS to store the actual
> values. Rather than adding another type in wined3d to hold the actual
> values or adding separate fields to IWineD3DSwapChainImpl, I've just
> changed WINED3DPRESENT_PARAMETERS to hold actual values rather than
> pointers, and copy stuff around in d3d8 / d3d9.
> Changelog:
It looks like the patch might be a bit large for the list, here's a
compressed version instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-wined3d_present_parameters.diff.txt.bz2
Type: application/x-bzip2
Size: 7241 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070216/ecf1b0c6/01-wined3d_present_parameters.diff.txt.bin

More information about the wine-patches mailing list