[resend] wininet/tests: Tell the user which ftp server we're using for the tests so he can try to connect to it manually in case of trouble.

Francois Gouget fgouget at free.fr
Tue Feb 20 08:56:50 CST 2007


---

I'm assuming it might not have been committed because of conflicts with 
Paul Vriens' patches, hence the resubmission.

The idea is that since we provide test binaries, the person running them 
may not have the source handy and thus not (readily) know which ftp 
server we tried to connect to. Once they know it's ftp.winehq.org, they 
can try to connect manualyl and thus determine if the problem is on 
their end (network down), or on the server's end (ftp server down).

Still this is mostly cosmetic/not that important.

 dlls/wininet/tests/ftp.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/dlls/wininet/tests/ftp.c b/dlls/wininet/tests/ftp.c
index c7bbdb9..c80552a 100644
--- a/dlls/wininet/tests/ftp.c
+++ b/dlls/wininet/tests/ftp.c
@@ -126,7 +126,7 @@ static void test_createdir(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
@@ -187,7 +187,7 @@ static void test_deletefile(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
@@ -263,7 +263,7 @@ static void test_getfile(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
@@ -417,7 +417,7 @@ static void test_openfile(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
@@ -543,7 +543,7 @@ static void test_putfile(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
@@ -640,7 +640,7 @@ static void test_removedir(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
@@ -709,7 +709,7 @@ static void test_renamefile(void)
     hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, 0, 0);
     if(!hFtp)
     {
-        skip("No ftp connection could be made\n");
+        skip("No ftp connection could be made to ftp.winehq.org\n");
         InternetCloseHandle(hInternet);
         return;
     }
-- 
1.4.4.4




More information about the wine-patches mailing list