IShellLink::GetIDList fix

Aric Stewart aric at codeweavers.com
Thu Feb 22 02:19:41 CST 2007


IShellLink::GetIDList when it fails to generate a PIDL must set ppidl to 
NULL or some applications think it contains valid data.
---
  dlls/shell32/shelllink.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
-------------- next part --------------
diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c
index 25f0753..61885ed 100644
--- a/dlls/shell32/shelllink.c
+++ b/dlls/shell32/shelllink.c
@@ -1744,7 +1744,10 @@ static HRESULT WINAPI IShellLinkW_fnGetI
     TRACE("(%p)->(ppidl=%p)\n",This, ppidl);
 
     if (!This->pPidl)
+    {
+	*ppidl = NULL;
         return S_FALSE;
+    }
     *ppidl = ILClone(This->pPidl);
     return S_OK;
 }


More information about the wine-patches mailing list