wininet: Constify a formal parameter of CommitURLCache{A|W}() (Resend)

Andrew Talbot Andrew.Talbot at talbotville.com
Mon Feb 26 15:28:09 CST 2007


What is wrong with this patch, please?

Thanks,

-- Andy.
---
Changelog:
    wininet: Constify a formal parameter of CommitURLCache{A|W}().

diff -urN a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c
--- a/dlls/wininet/urlcache.c	2006-10-25 17:37:04.000000000 +0100
+++ b/dlls/wininet/urlcache.c	2007-02-22 16:14:37.000000000 +0000
@@ -2012,7 +2012,7 @@
  *   The bug we are compensating for is that some drongo at Microsoft
  *   used lpHeaderInfo to pass binary data to CommitUrlCacheEntryA.
  *   As a consequence, CommitUrlCacheEntryA has been effectively
- *   redefined as LPBYTE rather than LPCSTR. But CommitUrlCacheEntryW
+ *   redefined as const BYTE * rather than LPCSTR. But CommitUrlCacheEntryW
  *   is still defined as LPCWSTR. The result (other than madness) is
  *   that we always need to store lpHeaderInfo in CP_ACP rather than
  *   in UTF16, and we need to avoid converting lpHeaderInfo in
@@ -2026,7 +2026,7 @@
     IN FILETIME ExpireTime,
     IN FILETIME LastModifiedTime,
     IN DWORD CacheEntryType,
-    IN LPBYTE lpHeaderInfo,
+    IN const BYTE *lpHeaderInfo,
     IN DWORD dwHeaderSize,
     IN LPCWSTR lpszFileExtension,
     IN LPCWSTR lpszOriginalUrl
@@ -2229,7 +2229,7 @@
     IN FILETIME ExpireTime,
     IN FILETIME LastModifiedTime,
     IN DWORD CacheEntryType,
-    IN LPBYTE lpHeaderInfo,
+    IN const BYTE *lpHeaderInfo,
     IN DWORD dwHeaderSize,
     IN LPCSTR lpszFileExtension,
     IN LPCSTR lpszOriginalUrl
@@ -2309,7 +2309,7 @@
     IN FILETIME ExpireTime,
     IN FILETIME LastModifiedTime,
     IN DWORD CacheEntryType,
-    IN LPWSTR lpHeaderInfo,
+    IN LPCWSTR lpHeaderInfo,
     IN DWORD dwHeaderSize,
     IN LPCWSTR lpszFileExtension,
     IN LPCWSTR lpszOriginalUrl
diff -urN a/include/wininet.h b/include/wininet.h
--- a/include/wininet.h	2006-11-07 17:36:37.000000000 +0000
+++ b/include/wininet.h	2007-02-22 16:05:40.000000000 +0000
@@ -1450,8 +1450,8 @@
 BOOLAPI CreateUrlCacheEntryW(LPCWSTR ,DWORD ,LPCWSTR ,LPWSTR ,DWORD);
 #define CreateUrlCacheEntry  WINELIB_NAME_AW(CreateUrlCacheEntry)
 
-BOOLAPI CommitUrlCacheEntryA(LPCSTR,LPCSTR,FILETIME,FILETIME,DWORD,LPBYTE,DWORD,LPCSTR,LPCSTR);
-BOOLAPI CommitUrlCacheEntryW(LPCWSTR,LPCWSTR,FILETIME,FILETIME,DWORD,LPWSTR,DWORD,LPCWSTR,LPCWSTR);
+BOOLAPI CommitUrlCacheEntryA(LPCSTR,LPCSTR,FILETIME,FILETIME,DWORD,const BYTE *,DWORD,LPCSTR,LPCSTR);
+BOOLAPI CommitUrlCacheEntryW(LPCWSTR,LPCWSTR,FILETIME,FILETIME,DWORD,LPCWSTR,DWORD,LPCWSTR,LPCWSTR);
 #define CommitUrlCacheEntry  WINELIB_NAME_AW(CommitUrlCacheEntry)
 
 BOOLAPI ResumeSuspendedDownload(HINTERNET, DWORD);



More information about the wine-patches mailing list