listview: Remove over constrained restriction on creating subitems.
fpga at pacbell.net
Fri Jan 5 13:26:56 CST 2007
When setting a subitem, fields other than text and image are invalid.
However, in Windows (tested in Win2K), if these fields are set, they are
simply ignored. In Wine, if any fields other than those two were set,
the field was not set at all. This was too restrictive.
This fixes beersmith.
Changelog: Remove over constrained restriction on creating subitems.
-------------- next part --------------
Subject: [PATCH] Remove over constrained restriction on creating subitems.
dlls/comctl32/listview.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 6340c87..1964703 100644
@@ -3506,7 +3506,6 @@ static BOOL set_sub_item(LISTVIEW_INFO *
if (lpLVItem->iSubItem >= DPA_GetPtrCount(infoPtr->hdpaColumns)) return FALSE;
/* First do some sanity checks */
- if (lpLVItem->mask & ~(LVIF_TEXT | LVIF_IMAGE)) return FALSE;
if (!(lpLVItem->mask & (LVIF_TEXT | LVIF_IMAGE))) return TRUE;
/* get the subitem structure, and create it if not there */
More information about the wine-patches