[PATCH 1/1] msi: MsiGetPropertyA return wrong length when called from a custom action.

Mike McCormack mike at codeweavers.com
Thu Jan 11 20:31:01 CST 2007


This is a hack, however the correct way to achieve bug compatiblity is 

MSI should run custom actions in a separate process and communicate with 
the main installer process via COM.  This is quite a lot of work which 
needs to be done anyway, but this patch will make us bug compatible with 
Microsoft's implementation in the mean time.

Furthermore, writing a test case for this behavior requires adding a dll 
contain custom action code to the dlls/msi/tests directory.  I can 
supply an MSVC project showing the problem.

See bug 5768 (http://bugs.winehq.org/show_bug.cgi?id=5768) for more details.


  dlls/msi/custom.c   |    2 ++
  dlls/msi/msi_main.c |    2 ++
  dlls/msi/msipriv.h  |    1 +
  dlls/msi/package.c  |   11 +++++++++++
  4 files changed, 16 insertions(+), 0 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: e539ba6bcaca7969036b7ecdb1b95db9ef5285cc.diff
Type: text/x-patch
Size: 2182 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070112/2e441217/e539ba6bcaca7969036b7ecdb1b95db9ef5285cc.bin

More information about the wine-patches mailing list