dsound: fix tests for old versions of windows

Francois Gouget fgouget at free.fr
Mon Jan 15 03:56:50 CST 2007


On Fri, 12 Jan 2007, Robert Reif wrote:

> This patch fixes the tests to they can run without crashing on old versions of
> windows that doesn't have dsound.dll.
> 
+    hDsound = LoadLibrary("dsound.dll");
+    if (hDsound)
     {
[...]
+        pDirectSoundCaptureEnumerateA=(void*)GetProcAddress(hDsound,
+            "DirectSoundCaptureEnumerateA");
+        if (pDirectSoundCaptureCreate && pDirectSoundCaptureEnumerateA)
+        {
[...]

If all dsound.dll implementations are supposed to have these functions 
(which I believe is the case), then I would test that we found them with 
an ok() call.

Also, if we fail to load dsound.dll, then we should indicate that we are 
skipping the tests with the new skip() function. This will make it 
clearer when analysing the logs that a big chunk of functionality was 
not tested (see the d3d8 tests for instance).

-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
                      Computers are like airconditioners
                They stop working properly if you open WINDOWS



More information about the wine-patches mailing list