winspool: Make fixme for PRINTER_ENUM_CONNECTIONS more silent

Detlef Riekenberg wine.dev at web.de
Sun Jan 21 13:49:34 CST 2007


Changelog:
 winspool: Make fixme for PRINTER_ENUM_CONNECTIONS more silent


Most times, this Flag is used together with other Flags.
(ENUM_PRINTERS_LOCAL)

A lot of Bug-Reports have this fixme as the last visible line
before a crash, because winspool.drv is loaded, 
but the line is not related to the crash.


-- 
 
By by ... Detlef

-------------- next part --------------
>From b28691f10456a5216fb90b6a21f01c34b3065be9 Mon Sep 17 00:00:00 2001
From: Detlef Riekenberg <wine.dev at web.de>
Date: Sun, 21 Jan 2007 20:42:11 +0100
Subject: [PATCH] winspool: Make fixme for PRINTER_ENUM_CONNECTIONS more silent
---
 dlls/winspool.drv/info.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c
index 79a9b94..2b96f45 100644
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -4047,9 +4047,15 @@ static BOOL WINSPOOL_EnumPrinters(DWORD 
 	return TRUE;
 
     if (dwType & PRINTER_ENUM_CONNECTIONS) {
-        FIXME("We don't handle PRINTER_ENUM_CONNECTIONS\n");
-	dwType &= ~PRINTER_ENUM_CONNECTIONS; /* we don't handle that */
-        if(!dwType) return TRUE;
+        TRACE("ignoring PRINTER_ENUM_CONNECTIONS\n");
+        dwType &= ~PRINTER_ENUM_CONNECTIONS; /* we don't handle that */
+        if (!dwType) {
+            FIXME("We don't handle PRINTER_ENUM_CONNECTIONS\n");
+            *lpdwNeeded = 0;
+            *lpdwReturned = 0;
+            return TRUE;
+        }
+
     }
 
     if (!((dwType & PRINTER_ENUM_LOCAL) || (dwType & PRINTER_ENUM_NAME))) {
-- 
1.4.1



More information about the wine-patches mailing list