Patch for Bugzilla Bug 6323

Dean Kusler deankus at gmail.com
Tue Jan 30 22:47:38 CST 2007


In dlls/winex11.drv/keyboard.c, XmbLookupString was being called with 
KeyRelease events, which has undefined behavior (in this case, it fails to 
return a valid keysym for numpad key releases). By instead calling 
XLookupString in the case of a KeyRelease, we can obtain a valid keysym.

From the XmbLookupString man page:
                                          Note

            (R)To ensure proper input processing, it is essential that the
            client pass only KeyPress events to XmbLookupString, XwcLookup-
            String and Xutf8LookupString.  Their behavior when a client
            passes a KeyRelease event is undefined.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: keyboard.c.patch
Type: text/x-diff
Size: 1089 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070130/a309171c/keyboard.c.bin


More information about the wine-patches mailing list