[9/10] gdiplus: added error checking on draw_polybezier

Evan Stade estade at gmail.com
Tue Jul 10 20:41:47 CDT 2007


Hi,

changelog:
*changed draw_polybezier to return a status (mainly to handle out of
memory errors)
*changed functions that use draw_polybezier to use this status

 dlls/gdiplus/graphics.c |   39 ++++++++++++++++++++++++++++++---------
 1 files changed, 30 insertions(+), 9 deletions(-)

-- 
Evan Stade
-------------- next part --------------
diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c
index 0ef90a8..939cd76 100644
--- a/dlls/gdiplus/graphics.c
+++ b/dlls/gdiplus/graphics.c
@@ -344,12 +344,24 @@ static void shorten_bezier_amt(GpPointF 
 
 /* Draws bezier curves between given points, and if caps is true then draws an
  * endcap at the end of the last line.  FIXME: Startcaps not implemented. */
-static void draw_polybezier(HDC hdc, GpPen *pen, GDIPCONST GpPointF * pt,
+static GpStatus draw_polybezier(HDC hdc, GpPen *pen, GDIPCONST GpPointF * pt,
     INT count, BOOL caps)
 {
-    POINT *pti = GdipAlloc(count * sizeof(POINT));
-    GpPointF *ptf = GdipAlloc(4 * sizeof(GpPointF));
+    POINT *pti;
+    GpPointF *ptf;
     INT i;
+    GpStatus status = GenericError;
+
+    if(!count)
+        return Ok;
+
+    pti = GdipAlloc(count * sizeof(POINT));
+    ptf = GdipAlloc(4 * sizeof(GpPointF));
+
+    if(!pti || !ptf){
+        status = OutOfMemory;
+        goto end;
+    }
 
     memcpy(ptf, &pt[count-4], 4 * sizeof(GpPointF));
 
@@ -371,8 +383,14 @@ static void draw_polybezier(HDC hdc, GpP
     }
 
     PolyBezier(hdc, pti, count);
+
+    status = Ok;
+
+end:
     GdipFree(pti);
     GdipFree(ptf);
+
+    return status;
 }
 
 /* Converts from gdiplus path point type to gdi path point type. */
@@ -530,6 +548,7 @@ GpStatus WINGDIPAPI GdipDrawArc(GpGraphi
 {
     INT save_state, num_pts;
     GpPointF points[MAX_ARC_PTS];
+    GpStatus retval;
 
     if(!graphics || !pen)
         return InvalidParameter;
@@ -540,11 +559,11 @@ GpStatus WINGDIPAPI GdipDrawArc(GpGraphi
     EndPath(graphics->hdc);
     SelectObject(graphics->hdc, pen->gdipen);
 
-    draw_polybezier(graphics->hdc, pen, points, num_pts, TRUE);
+    retval = draw_polybezier(graphics->hdc, pen, points, num_pts, TRUE);
 
     RestoreDC(graphics->hdc, save_state);
 
-    return Ok;
+    return retval;
 }
 
 GpStatus WINGDIPAPI GdipDrawBezier(GpGraphics *graphics, GpPen *pen, REAL x1,
@@ -552,6 +571,7 @@ GpStatus WINGDIPAPI GdipDrawBezier(GpGra
 {
     INT save_state;
     GpPointF pt[4];
+    GpStatus retval;
 
     if(!graphics || !pen)
         return InvalidParameter;
@@ -569,11 +589,11 @@ GpStatus WINGDIPAPI GdipDrawBezier(GpGra
     EndPath(graphics->hdc);
     SelectObject(graphics->hdc, pen->gdipen);
 
-    draw_polybezier(graphics->hdc, pen, pt, 4, TRUE);
+    retval = draw_polybezier(graphics->hdc, pen, pt, 4, TRUE);
 
     RestoreDC(graphics->hdc, save_state);
 
-    return Ok;
+    return retval;
 }
 
 /* Approximates cardinal spline with Bezier curves. */
@@ -584,6 +604,7 @@ GpStatus WINGDIPAPI GdipDrawCurve2(GpGra
     INT i, len_pt = count*3-2, save_state;
     GpPointF *pt;
     REAL x1, x2, y1, y2;
+    GpStatus retval;
 
     if(!graphics || !pen)
         return InvalidParameter;
@@ -622,12 +643,12 @@ GpStatus WINGDIPAPI GdipDrawCurve2(GpGra
     EndPath(graphics->hdc);
     SelectObject(graphics->hdc, pen->gdipen);
 
-    draw_polybezier(graphics->hdc, pen, pt, len_pt, TRUE);
+    retval = draw_polybezier(graphics->hdc, pen, pt, len_pt, TRUE);
 
     GdipFree(pt);
     RestoreDC(graphics->hdc, save_state);
 
-    return Ok;
+    return retval;
 }
 
 GpStatus WINGDIPAPI GdipDrawLineI(GpGraphics *graphics, GpPen *pen, INT x1,
-- 
1.4.1


More information about the wine-patches mailing list