msxml3: tests: aviod a crash that happens on some native systems
Mikołaj Zalewski
mikolaj at zalewski.pl
Wed Jul 18 17:05:31 CDT 2007
On some systems this createElement returns E_NOTIMPL and element is
NULL. I haven't yet looked into why - this patch only avoids a crash.
-------------- next part --------------
From f81be6c706c0d89d6fb0e5cf26a8ef6f808f63e4 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj at zalewski.pl>
Date: Thu, 12 Jul 2007 00:11:59 +0200
Subject: [PATCH] msxml3: tests: aviod a crash that happens on some native systems
---
dlls/msxml3/tests/xmldoc.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/dlls/msxml3/tests/xmldoc.c b/dlls/msxml3/tests/xmldoc.c
index 0c68896..feada7c 100644
--- a/dlls/msxml3/tests/xmldoc.c
+++ b/dlls/msxml3/tests/xmldoc.c
@@ -268,11 +268,14 @@ static void test_createElement(void)
ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
ok(element != NULL, "Expected non-NULL element\n");
- hr = IXMLElement_get_type(element, &type);
- ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
- ok(type == XMLELEMTYPE_OTHER, "Expected XMLELEMTYPE_OTHER, got %ld\n", type);
+ if (element != NULL)
+ {
+ hr = IXMLElement_get_type(element, &type);
+ ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+ ok(type == XMLELEMTYPE_OTHER, "Expected XMLELEMTYPE_OTHER, got %ld\n", type);
- IXMLElement_Release(element);
+ IXMLElement_Release(element);
+ }
/* invalid vName type */
V_VT(&vType) = VT_I4;
--
1.4.4.2
More information about the wine-patches
mailing list