msi: Simplify the code

Dmitry Timoshkov dmitry at codeweavers.com
Fri Jun 15 03:43:40 CDT 2007


Hello,

Changelog:
    msi: Simplify the code.

---
 dlls/msi/action.c |   24 +++++++-----------------
 1 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 00ed572..aa51e27 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -4587,30 +4587,20 @@ static LONG env_set_flags( LPCWSTR *name, LPWSTR *value, DWORD *flags )
     static const WCHAR prefix[] = {'[','~',']',0};
 
     *flags = 0;
-    while (*cptr && (*cptr == '=' || *cptr == '+' ||
-           *cptr == '-' || *cptr == '!' || *cptr == '*'))
+    while (*cptr)
     {
-        switch (*cptr)
-        {
-        case '=':
+        if (*cptr == '=')
             *flags |= ENV_ACT_SETALWAYS;
-            break;
-        case '+':
+        else if (*cptr == '+')
             *flags |= ENV_ACT_SETABSENT;
-            break;
-        case '-':
+        else if (*cptr == '-')
             *flags |= ENV_ACT_REMOVE;
-            break;
-        case '!':
+        else if (*cptr == '!')
             *flags |= ENV_ACT_REMOVEMATCH;
-            break;
-        case '*':
+        else if (*cptr == '*')
             *flags |= ENV_MOD_MACHINE;
+        else 
             break;
-        default:
-            ERR("Unknown Environment flag: %c\n", *cptr);
-            return ERROR_FUNCTION_FAILED;
-        }
 
         cptr++;
         (*name)++;
-- 
1.5.1.6






More information about the wine-patches mailing list