[PATCH 1/2] shell32: Conform to native in SHELL_ArgifyW for unquoted %1 in registry keys.

[Misha Koshelev]

PROS:
* Simplifies wine code
* Conforms to native (WinXP&Win98 tested, conformance test already in). Don't think there are any bugs about 
this non-native behavior in bugzilla per se, but even native shellapi.dll does not support quoted paths and 
would fail to install an inf file through ShellExecute inffile/Install verb without this patch. Also consider:
	- Windows apps process cmdline themselves, cannot assume they will be happy with a quotation where
	  they don't expect it
	- A program receiving a ddeexec string with an unexpected quotation would likely not handle it properly.
	  This is especially likely to be true for smaller/home-brewed programs that will probably never make it
	  to bugzilla.
* I tested all programs that have an unquoted %1 in the shell\verb\command or shell\verb\ddeexec string in HKCR in 
  a fresh .wine prefix. notepad, wordpad, winhelp, and setupapi all already handle unquoted filenames with spaces
  properly on the commandline.

CONS:
* msiexec registry keys will need "%1" instead of %1 in the shell\verb\command keys, which is the way it is on
  native (WinXP&Win98) too.

I believe pros win. Thanks

Misha


---
 dlls/shell32/shlexec.c       |   29 ++++-------------------------
 dlls/shell32/tests/shlexec.c |    2 +-
 2 files changed, 5 insertions(+), 26 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfb37dd5656745f2850b585e65dfe636b3eea413.diff
Type: text/x-patch
Size: 2353 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070616/c4853402/cfb37dd5656745f2850b585e65dfe636b3eea413.bin