setupapi: Simplify code as native setupapi does not handle quoted paths.

Misha Koshelev mk144210 at bcm.edu
Fri Jun 22 17:32:56 CDT 2007


So, as the conformance tests show, native setupapi does not handle quoted paths in InstallHinfSectionA/W
(personally tested on win98&xp). The SHELL_ArgifyW non-native behavior whereas all %1 parameters in command
and ddeexec registry keys were quoted has now been fixed. Therefore, using native programs, etc.,
InstallHinfSectionA/W should no longer have to deal with quoted paths, and since the code to implement
this quote handling here is non-trivial and not required, I believe that it should not be there.

The only caveat I see is if a user decides to do a wine rundll32 setupapi,InstallHinfSection 132 "nameofinffile"
setupapi will no longer be able to handle the quotes, but since it won't on native anyway I'm not sure this
is really a good reason to keep around quite a bit of complex quote handling code.
---
 dlls/setupapi/install.c       |   45 +++-------------------------------------
 dlls/setupapi/tests/install.c |    2 +-
 2 files changed, 5 insertions(+), 42 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 80a29dc4e63825c7ca4f1a22d2d366ddc6683b64.diff
Type: text/x-patch
Size: 2880 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070622/cac2bb50/80a29dc4e63825c7ca4f1a22d2d366ddc6683b64.bin


More information about the wine-patches mailing list