msi 5: Return ERROR_SUCCESS if the PackageName property is not present

James Hawkins truiken at gmail.com
Wed Jun 27 18:31:54 CDT 2007


Hi,

Changelog:
* Return ERROR_SUCCESS if the PackageName property is not present.

 dlls/msi/source.c       |    2 +-
 dlls/msi/tests/source.c |    5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
James Hawkins
-------------- next part --------------
diff --git a/dlls/msi/source.c b/dlls/msi/source.c
index e636cb7..58b8049 100644
--- a/dlls/msi/source.c
+++ b/dlls/msi/source.c
@@ -333,7 +333,7 @@ UINT WINAPI MsiSourceListGetInfoW( LPCWS
         rc = RegQueryValueExW(sourcekey, INSTALLPROPERTY_PACKAGENAMEW, 0, 0, 
                 (LPBYTE)szValue, pcchValue);
         if (rc != ERROR_SUCCESS && rc != ERROR_MORE_DATA)
-            rc = ERROR_UNKNOWN_PROPERTY;
+            rc = ERROR_SUCCESS;
     }
     else
     {
diff --git a/dlls/msi/tests/source.c b/dlls/msi/tests/source.c
index d7b15f3..546217f 100644
--- a/dlls/msi/tests/source.c
+++ b/dlls/msi/tests/source.c
@@ -208,10 +208,7 @@ static void test_MsiSourceListGetInfo(vo
     size = 0xdeadbeef;
     r = MsiSourceListGetInfoA(prodcode, usersid, MSIINSTALLCONTEXT_USERUNMANAGED,
                               MSICODE_PRODUCT, INSTALLPROPERTY_PACKAGENAME, NULL, &size);
-    todo_wine
-    {
-        ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);
-    }
+    ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);
     ok(size == 0, "Expected 0, got %d\n", size);
 
     data = "msitest.msi";
-- 
1.4.1


More information about the wine-patches mailing list