[PATCH 5/5] shell32: Fix shelllink creation to non-executable files and remove unnecessary code.

Misha Koshelev mk144210 at bcm.edu
Thu Jun 28 20:00:30 CDT 2007

Makes shelllink conform to win98 & winxp behavior.

I tested ShellLinks created after this patch for executables (& non-executables) and did not run into any 
problems. Also, since IShellLinkW_fnSetPath (and IShellLinkA_fnSetPath, which calls the W version) already do a 
GetFullPathName and store the full path name, the call to SHELL_FindExecutable is quite superfluous here in any case. 
I tried to track its creation down with gitk and did not find its exact origin, but saw that IShellLink's 
internal storage of paths had changed through the times from relative paths to PIDLs and now to absolute paths, 
and I am assuming this call is a remnant from one of those eras.
 dlls/shell32/shelllink.c       |   19 +------------------
 dlls/shell32/tests/shelllink.c |    2 +-
 2 files changed, 2 insertions(+), 19 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a4f2707dee4cf54025e0541211e24ae219cdc932.diff
Type: text/x-patch
Size: 2017 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070628/ec152d98/a4f2707dee4cf54025e0541211e24ae219cdc932.bin

More information about the wine-patches mailing list