comctl32: Fix my last patch

Felix Nawothnig flexo at
Sat Mar 10 07:29:07 CST 2007

My last patch was wrong and caused some nasty regressions. Mapping 
CLR_DEFAULT to the global defaults seem to be what native does.

In fact it was also what the old code did - it mapped CLR_DEFAULT to the 
currectly selected DC bk color at some point during the refresh. This 
just happened to be the same as clrWindow.

I also implemented this behaviour for clrText (again native relay logs 
show this behaviour).

The downside: Seems I can't write a testcase for this (I would need to 
hook into the DC to figure out what colors are used for drawing - any 
idea?). The test I submitted yesterday just shows that native saves & 
restores between the callbacks (so I restored the todo_wine because we 
still don't do that).
  dlls/comctl32/listview.c       |   10 +++++++---
  dlls/comctl32/tests/listview.c |    4 ++--
  2 files changed, 9 insertions(+), 5 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 220b4d16913234d61189087f4e2c2eb767eb8b70.diff
Type: text/x-patch
Size: 2171 bytes
Desc: not available
Url :

More information about the wine-patches mailing list