dlls/cabinet/fdi.c cleanup

Gerald Pfeifer gerald at pfeifer.com
Wed Mar 14 14:49:42 CDT 2007


userpath is a local variable here  and "(userpath)" will always evaluate
to the address of that variable which is non-NULL.  We can thus simplify
the statement as per my patch below.

Gerald

ChangeLog:
Simplify code in fdi_decomp().
Index: fdi.c
===================================================================
RCS file: /home/wine/wine/dlls/cabinet/fdi.c,v
retrieving revision 1.29
diff -u -p -r1.29 fdi.c
--- fdi.c	14 Feb 2007 15:29:12 -0000	1.29
+++ fdi.c	14 Mar 2007 19:47:55 -0000
@@ -2108,7 +2108,7 @@ static int fdi_decomp(struct fdi_file *f
 
           do {
 
-            pathlen = (userpath) ? strlen(userpath) : 0;
+            pathlen = strlen(userpath);
             filenamelen = (cab->mii.nextname) ? strlen(cab->mii.nextname) : 0;
 
             /* slight overestimation here to save CPU cycles in the developer's brain */



More information about the wine-patches mailing list