[wininet/ftp #2] Fix potential memory leak

Paul Vriens paul.vriens.wine at gmail.com
Wed Mar 21 11:56:09 CDT 2007


Hi,

we weren't freeing memory on a failure path.

Changelog
    Fix potential memory leak

Cheers,

Paul.

-------------- next part --------------
>From 42f87f14b06cb663ab8aa36bac7580769ae7ba54 Mon Sep 17 00:00:00 2001
From: Paul Vriens <Paul.Vriens.Wine at gmail.com>
Date: Wed, 21 Mar 2007 17:51:31 +0100
Subject: [PATCH] Fix potential memory leak

---
 dlls/wininet/ftp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/wininet/ftp.c b/dlls/wininet/ftp.c
index 73d51e8..40026fd 100644
--- a/dlls/wininet/ftp.c
+++ b/dlls/wininet/ftp.c
@@ -2825,9 +2825,10 @@ static BOOL FTP_RetrieveFileData(LPWININETFTPSESSIONW lpwfs, INT nDataSocket, DW
     }
 
     TRACE("Data transfer complete\n");
-    HeapFree(GetProcessHeap(), 0, lpszBuffer);
 
 recv_end:
+    HeapFree(GetProcessHeap(), 0, lpszBuffer);
+
     return  (nRC != -1);
 }
 
-- 
1.4.4.2




More information about the wine-patches mailing list