winedump: '$' isn't a valid character in an identifier regardless that gcc accepts it without warning.

Michael Stefaniuc mstefani at redhat.de
Wed May 23 16:34:01 CDT 2007


I don't find '$' as accepted character in the K&R C book nor will it be
introduced in the next C standard
http://c0x.coding-guidelines.com/5.2.1.html
Sparse tripped over this.
---
 tools/winedump/lib.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/winedump/lib.c b/tools/winedump/lib.c
index 155a6fa..85f305d 100644
--- a/tools/winedump/lib.c
+++ b/tools/winedump/lib.c
@@ -106,9 +106,9 @@ static void dump_long_import(const void *base, const IMAGE_SECTION_HEADER *ish,
         }
         else if (globals.do_debug && !strcmp((const char *)ish[i].Name, ".debug$S"))
         {
-            const char *imp_debug$ = (const char *)base + ish[i].PointerToRawData;
+            const char *imp_debugS = (const char *)base + ish[i].PointerToRawData;
 
-            codeview_dump_symbols(imp_debug$, ish[i].SizeOfRawData);
+            codeview_dump_symbols(imp_debugS, ish[i].SizeOfRawData);
             printf("\n");
         }
     }
-- 
1.5.0.6


-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani at redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070523/8609938a/attachment.pgp


More information about the wine-patches mailing list