#1 wininet: Fix a number of problems with InternetSetCookie.

Hans Leidekker hans at it.vu.nl
Sun Nov 11 06:35:39 CST 2007


When called without a cookie name InternetSetCookie parses the data parameter
and recursively calls itself. This is problematic on its own, but there's also
an incorrect assumption in the parsing in that it expects an equal sign to be
present, which is simply not required (as shown by current tests).

Furthermore, the implementation calls InternetCrackUrl on the supplied URL but
ignores any error, and it would also go ahead and add a cookie for an empty
domain, which doesn't really make sense.

Applies after "wininet: update test to pass on newer versions of windows" by
Lei Zhang.

 -Hans

Changelog
 Fix a number of problems with InternetSetCookie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wininet_cookie_01.diff
Type: text/x-diff
Size: 6753 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071111/dbd3fd26/attachment-0001.diff 


More information about the wine-patches mailing list