programs/winedbg/types.c -- fix type of loop variable (RESEND)

Gerald Pfeifer gerald at pfeifer.com
Thu Nov 15 14:06:26 CST 2007


Can this one be considered?  I'll focus on true bugs ("always false") 
issues going forward, but for those patches for other stuff I have done 
already it would be nice to see them considered.

Gerald

---------- Forwarded message ----------
From: Gerald Pfeifer <gerald at pfeifer.com>
To:  <wine-patches at winehq.org>
Date: Sat, 3 Nov 2007 14:47:51 +0100 (CET)
Subject: programs/winedbg/types.c -- fix type of loop variable

ChangeLog:
Fix type of loop variable in types_udt_find_element().

Along the way I also reduced the scope of the variable, which makes
the code easier to read.

Index: programs/winedbg/types.c
===================================================================
RCS file: /home/wine/wine/programs/winedbg/types.c,v
retrieving revision 1.31
diff -u -3 -p -r1.31 types.c
--- programs/winedbg/types.c	3 Aug 2007 13:06:30 -0000	1.31
+++ programs/winedbg/types.c	3 Nov 2007 13:45:01 -0000
@@ -259,7 +259,6 @@ BOOL types_udt_find_element(struct dbg_l
     TI_FINDCHILDREN_PARAMS*     fcp = (TI_FINDCHILDREN_PARAMS*)buffer;
     WCHAR*                      ptr;
     char                        tmp[256];
-    int                         i;
     struct dbg_type             type;
 
     if (!types_get_info(&lvalue->type, TI_GET_SYMTAG, &tag) ||
@@ -274,6 +273,7 @@ BOOL types_udt_find_element(struct dbg_l
             fcp->Count = min(count, 256);
             if (types_get_info(&lvalue->type, TI_FINDCHILDREN, fcp))
             {
+                unsigned i;
                 type.module = lvalue->type.module;
                 for (i = 0; i < min(fcp->Count, count); i++)
                 {



More information about the wine-patches mailing list