advapi32/service.c -- remove untriggerable check

Gerald Pfeifer gerald at pfeifer.com
Sun Nov 18 00:03:09 CST 2007


n is of type DWORD which is unsigned, so n < 0 always will evaluate to 
false.

Gerald

ChangeLog:
Remove untriggerable check.

Index: dlls/advapi32/service.c
===================================================================
RCS file: /home/wine/wine/dlls/advapi32/service.c,v
retrieving revision 1.160
diff -u -3 -p -r1.160 service.c
--- dlls/advapi32/service.c	15 Oct 2007 16:29:59 -0000	1.160
+++ dlls/advapi32/service.c	18 Nov 2007 06:01:28 -0000
@@ -2107,9 +2107,6 @@ QueryServiceConfigW( SC_HANDLE hService,
         n -= sizeof(WCHAR);
     }
 
-    if( n < 0 )
-        ERR("Buffer overflow!\n");
-
     TRACE("Image path           = %s\n", debugstr_w(lpServiceConfig->lpBinaryPathName) );
     TRACE("Group                = %s\n", debugstr_w(lpServiceConfig->lpLoadOrderGroup) );
     TRACE("Dependencies         = %s\n", debugstr_w(lpServiceConfig->lpDependencies) );



More information about the wine-patches mailing list