msi atou return value mistake

Patrick Moran patrick.a.moran at
Sun Nov 25 01:35:27 CST 2007

Hello all,

If I'm submitting anything in the wrong form, I apologize. This is my
first patch submission as well as my first use of git, so I'm not sure
of myself.

I fetched a tree and was browsing about msiexec.c, when I noticed that
in msi_atou(), the DWORD is calculated, but at the end 0 is always
returned. The attached patch should fix this by simply returning ret
instead of 0.

Also, I'm not yet subscribed to this list, so if my patch is poorly
formatted or there is some other error or question, please add this
email address to the reply. Many thanks.

Patrick Moran
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msi_bad_return.diff
Type: text/x-patch
Size: 327 bytes
Desc: not available
Url : 

More information about the wine-patches mailing list