version resource for ole2nls.dll

[Stefan Leichter]

Am Friday 28 September 2007 05:23 schrieb Dmitry Timoshkov:
> "Dmitry Timoshkov" <dmitry at codeweavers.com> wrote:
> > "Stefan Leichter" <Stefan.Leichter at camline.com> wrote:
> >> This patch fixes Bug 9747
> >>
> >> ChangeLog
> >> ---------
> >> added version resource for ole2nls.dll
> >>
> >> +#define WINE_FILEVERSION_STR "2.10.3050.1"
> >> +#define WINE_FILEDESCRIPTION_STR "Wine OLE dll"
> >> +#define WINE_FILENAME_STR "OLE2NLS.DLL"
> >> +
> >> +#include "wine/wine_common_ver.rc"
> >
> > Why do you define WINE_FILEVERSION_STR but not WINE_FILEVERSION?
> > That not creates a confusion but could lead to hard debuggable
> > problems with application which test only one of them.
>
> The above should be read as:
>
> That not only creates a confusion but could lead to hard debuggable
> problems with application which test only one of them.

Ok, looks like i picked a bad example from the wine tree.

ChangeLog
---------
	define WINE_FILEVERSION in version resource of ole2nls.dll too
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ole2nls.diff
Type: text/x-diff
Size: 414 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070929/e9182232/attachment.diff