dlls/d3d9/tests/visual.c cleanup

Gerald Pfeifer gerald at pfeifer.com
Tue Apr 8 11:08:15 CDT 2008


On Mon, 14 Jan 2008, Alexandre Julliard wrote:
> These tests don't make much sense, with or without your fix, plus the
> error messages don't match the tests. This needs more work.

It seems this was added with 2007-11-07 with the following log entry:

  Stefan Dösinger <stefan at codeweavers.com>
  wined3d: Shader Model 3.0 varying tests.

I've seen patches in this area cleaning up some stuff.  Does this
address the issues you were seeing?  Otherwise, I'd hope Stefan can
have a look.

Here is an updated patch of mine.

Gerald

ChangeLog:
Remove two useless checks.

Index: dlls/d3d9/tests/visual.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d9/tests/visual.c,v
retrieving revision 1.109
diff -u -3 -p -r1.109 visual.c
--- dlls/d3d9/tests/visual.c	7 Apr 2008 19:49:16 -0000	1.109
+++ dlls/d3d9/tests/visual.c	8 Apr 2008 15:10:59 -0000
@@ -5446,12 +5446,12 @@ static void vshader_version_varying_test
        "vs_3_0 returned color 0x%08x, expected 0x00203366\n", color);
     color = getPixelColor(device, 160, 360);
     ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 &&
-       (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 &&
+                                             (color & 0x0000ff00) <= 0x00000000 &&
        (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00000068,
        "vs_1_1 returned color 0x%08x, expected 0x004c0066\n", color);
     color = getPixelColor(device, 480, 360);
     ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 &&
-       (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 &&
+                                             (color & 0x0000ff00) <= 0x00000000 &&
        (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00000068,
        "vs_2_0 returned color 0x%08x, expected 0x004c0066\n", color);
 


More information about the wine-patches mailing list