quartz: Add missing lock releases on some code paths (Smatch).

Michael Stefaniuc mstefani at redhat.de
Tue Apr 8 16:13:19 CDT 2008


---
Maarten,

not sure if it's supposed to not release the thread_lock in that case
or if that's an omission that got copied around.


 dlls/quartz/parser.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/quartz/parser.c b/dlls/quartz/parser.c
index 670a0c3..a369de2 100644
--- a/dlls/quartz/parser.c
+++ b/dlls/quartz/parser.c
@@ -223,6 +223,7 @@ static HRESULT WINAPI Parser_Stop(IBaseFilter * iface)
         if (This->state == State_Stopped)
         {
             LeaveCriticalSection(&This->csFilter);
+            LeaveCriticalSection(&pin->thread_lock);
             return S_OK;
         }
         This->state = State_Stopped;
@@ -248,6 +249,7 @@ static HRESULT WINAPI Parser_Pause(IBaseFilter * iface)
     if (This->state == State_Paused)
     {
         LeaveCriticalSection(&This->csFilter);
+        LeaveCriticalSection(&pin->thread_lock);
         return S_OK;
     }
 
@@ -284,6 +286,7 @@ static HRESULT WINAPI Parser_Run(IBaseFilter * iface, REFERENCE_TIME tStart)
         if (This->state == State_Running)
         {
             LeaveCriticalSection(&This->csFilter);
+            LeaveCriticalSection(&pin->thread_lock);
             return S_OK;
         }
 
-- 
1.5.5.rc3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080408/08f69da4/attachment.pgp 


More information about the wine-patches mailing list