[1/2] WineD3D: Do not activate CTXUSAGE_BLIT for fb -> texture reading
stefan at codeweavers.com
Wed Apr 9 17:42:04 CDT 2008
Alexandre: please do not apply until Roderick confirms this is correct
This ActivateContext call slipped in with patch
ba90a740beb9ce9a839cc843db8d87f5a37becdd. Roderick, was there a particular
reason why you activate CTXUSAGE_BLIT here, or was it just a copypaste
mistake from the glReadPixels codepath? None of the BLIT states *should*
affect glCopyTexImage2D. As stated in the comment, the glReadPixel path sets
it to work around some driver issues on Mesa, but I haven't seen a driver
having issues with glCopyTexImage2D in that regard.
I came across this patch because it subtly broke offscreen rendering in Guild
Wars(Linux nvidia). That's also not quite right since the states should be
orthogonal to glCopyTexImage2D. I am having some issues on MacOS too.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2372 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080410/a3be4000/attachment.patch
More information about the wine-patches