WineD3D: WineD3D: Use the shader backend to enable / disable atifs and nvts

[H. Verbeet]

On 11/04/2008, Stefan Dösinger <stefan at codeweavers.com> wrote:
> Am Freitag, 11. April 2008 00:31:13 schrieb Stefan Dösinger:
>
> > The drawback of this is that now the workaround for the mesa atifs bug
>  > minimally affects nvidia cards too. It's a bit tricky to design around
>  > driver bugs :-/
>
> Use this patch instead, the last one had a small but pretty bad bug that
>  broken GLSL
>
This patch doesn't make sense at all. Wasn't ATIFS supposed to be an
implementation of fixed function fragment processing for ATI cards? In
that case it doesn't make sense to only use it on cards that don't
support ARB or GLSL. That will only make newer ATI cards have worse
fixed function fragment processing (assuming ATIFS works as
advertised). Of course what it comes down to again is that the shader
backend isn't the right place to implement this. (Not to mention the
issue of making a workaround for a Mesa bug part of the shader
infrastructure... that bug should be fixed in Mesa.)

> +    void (*shader_fragment_enable)(IWineD3DDevice *iface, BOOL enable);
The name "shader_fragment_enable" is ambiguous at best within the
context of a shader backend.