IWineD3DBaseTextureImpl_SetAutoGenFilterType missing break inside switch

Hoehle, Joerg-Cyril Joerg-Cyril.Hoehle at t-systems.com
Mon Apr 14 10:16:25 CDT 2008


regardless of issue
which suggests that the function is incorrect it its use of GL parameters, so it needs fixing, you may wish to apply the following (minor) patch.

missing break inside switch

2008-04-03  Jörg Höhle <hoehle at users.sourceforge.net>

	* dlls/dsound/basetexture.c:
	d3d_texture: missing break inside switch in SetAutoGenFilterType.

--- basetexture.c~	2008-04-09 20:55:46.000000000 +0200
+++ dlls/wined3d/basetexture.c	2008-04-10 21:17:50.000000000 +0200
@@ -198,10 +198,12 @@
               glTexParameteri(textureDimensions, GL_GENERATE_MIPMAP_HINT_SGIS, GL_FASTEST);
               checkGLcall("glTexParameteri(textureDimensions, GL_GENERATE_MIPMAP_HINT_SGIS, GL_FASTEST)");
+              break;
           case WINED3DTEXF_LINEAR:
               glTexParameteri(textureDimensions, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST);
               checkGLcall("glTexParameteri(textureDimensions, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST)");
+              break;
               WARN("Unexpected filter type %d, setting to GL_NICEST\n", FilterType);
               glTexParameteri(textureDimensions, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST);

This patch code is put under the same copyright as wine as of version
0.9.59, c.f. src/git/wine/{LICENSE,COPYING.LIB}

 Jörg Höhle

More information about the wine-patches mailing list