[PATCH] winex11: fix buffer overflow in imm channel resulting from excesive FIXME's without \n. Avoid spamming by turning FIXME's into TRACE's.
Alex Villacís Lasso
alex at karlalex.palosanto.com
Tue Apr 29 22:27:09 CDT 2008
---
dlls/winex11.drv/ime.c | 32 ++++++++++++++++----------------
1 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c
index ffd8e80..e628e87 100644
--- a/dlls/winex11.drv/ime.c
+++ b/dlls/winex11.drv/ime.c
@@ -640,20 +640,20 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwIndex, DWORD dwValue)
switch (dwAction)
{
- case NI_OPENCANDIDATE: FIXME("NI_OPENCANDIDATE\n"); break;
- case NI_CLOSECANDIDATE: FIXME("NI_CLOSECANDIDATE\n"); break;
- case NI_SELECTCANDIDATESTR: FIXME("NI_SELECTCANDIDATESTR\n"); break;
- case NI_CHANGECANDIDATELIST: FIXME("NI_CHANGECANDIDATELIST\n"); break;
- case NI_SETCANDIDATE_PAGESTART: FIXME("NI_SETCANDIDATE_PAGESTART\n"); break;
- case NI_SETCANDIDATE_PAGESIZE: FIXME("NI_SETCANDIDATE_PAGESIZE\n"); break;
+ case NI_OPENCANDIDATE: TRACE("NI_OPENCANDIDATE\n"); break;
+ case NI_CLOSECANDIDATE: TRACE("NI_CLOSECANDIDATE\n"); break;
+ case NI_SELECTCANDIDATESTR: TRACE("NI_SELECTCANDIDATESTR\n"); break;
+ case NI_CHANGECANDIDATELIST: TRACE("NI_CHANGECANDIDATELIST\n"); break;
+ case NI_SETCANDIDATE_PAGESTART: TRACE("NI_SETCANDIDATE_PAGESTART\n"); break;
+ case NI_SETCANDIDATE_PAGESIZE: TRACE("NI_SETCANDIDATE_PAGESIZE\n"); break;
case NI_CONTEXTUPDATED:
- FIXME("NI_CONTEXTUPDATED:");
+ TRACE("NI_CONTEXTUPDATED:");
switch (dwValue)
{
- case IMC_SETCOMPOSITIONWINDOW: FIXME("IMC_SETCOMPOSITIONWINDOW\n"); break;
- case IMC_SETCONVERSIONMODE: FIXME("IMC_SETCONVERSIONMODE\n"); break;
- case IMC_SETSENTENCEMODE: FIXME("IMC_SETSENTENCEMODE\n"); break;
- case IMC_SETCANDIDATEPOS: FIXME("IMC_SETCANDIDATEPOS\n"); break;
+ case IMC_SETCOMPOSITIONWINDOW: TRACE("IMC_SETCOMPOSITIONWINDOW\n"); break;
+ case IMC_SETCONVERSIONMODE: TRACE("IMC_SETCONVERSIONMODE\n"); break;
+ case IMC_SETSENTENCEMODE: TRACE("IMC_SETSENTENCEMODE\n"); break;
+ case IMC_SETCANDIDATEPOS: TRACE("IMC_SETCANDIDATEPOS\n"); break;
case IMC_SETCOMPOSITIONFONT:
{
LPIMEPRIVATE myPrivate;
@@ -694,7 +694,7 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwIndex, DWORD dwValue)
bRet = TRUE;
}
break;
- default: FIXME("Unknown\n"); break;
+ default: TRACE("Unknown\n"); break;
}
break;
case NI_COMPOSITIONSTR:
@@ -753,8 +753,8 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwIndex, DWORD dwValue)
bRet = TRUE;
}
break;
- case CPS_CONVERT: FIXME("CPS_CONVERT\n"); break;
- case CPS_REVERT: FIXME("CPS_REVERT\n"); break;
+ case CPS_CONVERT: TRACE("CPS_CONVERT\n"); break;
+ case CPS_REVERT: TRACE("CPS_REVERT\n"); break;
case CPS_CANCEL:
{
LPIMEPRIVATE myPrivate;
@@ -777,10 +777,10 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwIndex, DWORD dwValue)
bRet = TRUE;
}
break;
- default: FIXME("Unknown\n"); break;
+ default: TRACE("Unknown\n"); break;
}
break;
- default: FIXME("Unknown Message\n"); break;
+ default: TRACE("Unknown Message\n"); break;
}
UnlockRealIMC(hIMC);
--
1.5.4.1
--------------040606010908040402060903--
More information about the wine-patches
mailing list