kernel32: Tiny improvement to the GetVolumePathNameW stub (try 3)

Louis. Lenders xerox_xerox2000 at yahoo.co.uk
Sat Aug 16 18:56:16 CDT 2008


Hi Michael, thanks again for the comment, i moved the check for the stringlength to the front, and removed the wrong check for the bufferlength (oops).
 As for the other suggestions and the tests: I tried to keep the patch as minimal as possible, that's why it said _tiny_ improvement in the changelog. For now it fixes the bug, and returns something more useful then we have now IMHO. If the patch is rejected because of missing tests or additional error checks than that's a pity, sorry, i still have to fix up a test for another patch.



Hi,  this fixes Adobe Lightroom 2.0 start up bug, mentioned in 

http://bugs.winehq.org/show_bug.cgi?id=8224#c4

as long wine doesn't handle with volume mount points, it's probably safe to satisfy most apps.

(A simple google for 
"fixme:volume:GetVolumePathNameW"
revealed only about 3 apps , and "fixme:volume:GetVolumePathNameA" revealed zero hits, so for now the use of this api seems not really wide-spread, and no need to touch GetVolumePathNameA i guess)



Send instant messages to your online friends http://uk.messenger.yahoo.com 

Send instant messages to your online friends http://uk.messenger.yahoo.com 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-patches/attachments/20080816/b38aa855/attachment.htm 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: c.txt
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20080816/b38aa855/attachment.txt 


More information about the wine-patches mailing list