appwiz.cpl: It's ok to use "SysListView32" directly.
Francois Gouget
fgouget at free.fr
Tue Dec 9 08:05:28 CST 2008
---
I think it's ok to use "SysListView32": all the other resources do it,
and we do the same for "button", "static", etc. (of course these don't
have corresponding macros anyway).
But if using the macro is preferred, I can send a patch that does so
consistently in Wine. And in that case the macro to use is WC_LISTVIEWA.
dlls/appwiz.cpl/En.rc | 2 --
dlls/appwiz.cpl/Fr.rc | 2 --
dlls/appwiz.cpl/Ja.rc | 2 --
dlls/appwiz.cpl/Ko.rc | 2 --
dlls/appwiz.cpl/Nl.rc | 2 --
dlls/appwiz.cpl/No.rc | 2 --
dlls/appwiz.cpl/Pt.rc | 2 --
dlls/appwiz.cpl/Ru.rc | 2 --
dlls/appwiz.cpl/Si.rc | 2 --
dlls/appwiz.cpl/Zh.rc | 4 ----
10 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/dlls/appwiz.cpl/En.rc b/dlls/appwiz.cpl/En.rc
index f04af8e..d0b4de3 100644
--- a/dlls/appwiz.cpl/En.rc
+++ b/dlls/appwiz.cpl/En.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "Version"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "Install/Uninstall"
diff --git a/dlls/appwiz.cpl/Fr.rc b/dlls/appwiz.cpl/Fr.rc
index 20bfa6e..8dbdff1 100644
--- a/dlls/appwiz.cpl/Fr.rc
+++ b/dlls/appwiz.cpl/Fr.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "Version"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "Installation/D?sinstallation"
diff --git a/dlls/appwiz.cpl/Ja.rc b/dlls/appwiz.cpl/Ja.rc
index 4a9cdb9..b0d5717 100644
--- a/dlls/appwiz.cpl/Ja.rc
+++ b/dlls/appwiz.cpl/Ja.rc
@@ -38,8 +38,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "???????????????"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "?????????????????????????????????????????????"
diff --git a/dlls/appwiz.cpl/Ko.rc b/dlls/appwiz.cpl/Ko.rc
index 2c01136..e2bd60a 100644
--- a/dlls/appwiz.cpl/Ko.rc
+++ b/dlls/appwiz.cpl/Ko.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "????"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "????/????"
diff --git a/dlls/appwiz.cpl/Nl.rc b/dlls/appwiz.cpl/Nl.rc
index 82d8f21..4abee57 100644
--- a/dlls/appwiz.cpl/Nl.rc
+++ b/dlls/appwiz.cpl/Nl.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "Versie"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "Installeren/Verwijderen"
diff --git a/dlls/appwiz.cpl/No.rc b/dlls/appwiz.cpl/No.rc
index 0060ea0..2b15cbb 100644
--- a/dlls/appwiz.cpl/No.rc
+++ b/dlls/appwiz.cpl/No.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "Versjon"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "Installer/Avinstaller"
diff --git a/dlls/appwiz.cpl/Pt.rc b/dlls/appwiz.cpl/Pt.rc
index f38bba5..31c7d8a 100644
--- a/dlls/appwiz.cpl/Pt.rc
+++ b/dlls/appwiz.cpl/Pt.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "Vers?o"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "Instalar/Desinstalar"
diff --git a/dlls/appwiz.cpl/Ru.rc b/dlls/appwiz.cpl/Ru.rc
index 4510c5e..49322e4 100644
--- a/dlls/appwiz.cpl/Ru.rc
+++ b/dlls/appwiz.cpl/Ru.rc
@@ -35,8 +35,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "??????"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 235
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "?????????/????????"
diff --git a/dlls/appwiz.cpl/Si.rc b/dlls/appwiz.cpl/Si.rc
index dd6601d..83f2d4b 100644
--- a/dlls/appwiz.cpl/Si.rc
+++ b/dlls/appwiz.cpl/Si.rc
@@ -37,8 +37,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "Razli??ica"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "Dodaj/odstrani programe"
diff --git a/dlls/appwiz.cpl/Zh.rc b/dlls/appwiz.cpl/Zh.rc
index 8f67b0c..247cbfa 100644
--- a/dlls/appwiz.cpl/Zh.rc
+++ b/dlls/appwiz.cpl/Zh.rc
@@ -38,8 +38,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "??????"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "??????/??????"
@@ -97,8 +95,6 @@ STRINGTABLE
IDS_COLUMN_VERSION, "??????"
}
-/* TODO: it's best to use the constant WC_LISTVIEW instead of SysListView32 directly, but the Wine resource compiler doesn't seem to like that... */
-
IDD_MAIN DIALOG 0, 0, 320, 220
STYLE DS_MODALFRAME | DS_3DLOOK | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
CAPTION "??????/??????"
--
1.5.6.5
More information about the wine-patches
mailing list