[resend3] gdi32/tests: Add a test for GdiGetCodePage().

ByeongSik Jeon bsjeon at hanmail.net
Sun Dec 14 08:40:32 CST 2008


http://bugs.winehq.org/show_bug.cgi?id=16325

2008-12-14 (Sun), 14:45 +0100, Paul Vriens wrote: 
> Hi,
> 
> The trace() is worse. The first one should be a win_skip() the second 
> one a skip(), so:
> 
>      if (!pGdiGetCodePage)
>      {
>          win_skip("GdiGetCodePage not available on this platform\n");
>          return;
>      }
> 
>      if (!is_font_installed( "Arial" ) )
>      {
>          skip("Arial is not installed\n");
>          return;
>      }
> 
> The win_skip() means we skip the test on Windows if this function is not 
> present but it will fail on Wine if this function is not 
> there(exported). This will make sure that nobody messes up this function .
> 
> The skip() will make sure we skip the tests on all platforms if Arial is 
> not available.
> 
> For that second item. Isn't it enough to put the GetDC() before the 
> for-loop and the ReleaseDC after the for-loop?
> 
Thank you.

---
 dlls/gdi32/tests/Makefile.in |    2 +-
 dlls/gdi32/tests/font.c      |  154 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 155 insertions(+), 1 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: d998867963b085de8a458e7eddb93b7f0b6e3f13.diff
Type: text/x-patch
Size: 6665 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20081214/5955c7ac/attachment-0001.bin 


More information about the wine-patches mailing list