richedit: Removed redundant editor height variables and calculations.

Dylan Smith dylan.ah.smith at
Fri Dec 19 07:15:04 CST 2008

During wrapping there were three different heights that were being
stored, with only one of them being done correctly.  The other ones
failed to incorporate the height of the paragraph or row, so ended up
being incorrect.

The bug can be seen in wordpad by entering several lines of text, then
resizing the height of the window to see when the vertical scrollbar
gets shown.  It can be seen that the last row can almost completely
hidden without the vertical scrollbar being shown.  I checked with
wordpad on Windows XP, and this is indeed inconsistent.
 dlls/riched20/editor.c  |    1 -
 dlls/riched20/editstr.h |    1 -
 dlls/riched20/paint.c   |    4 ++--
 dlls/riched20/wrap.c    |   15 +--------------
 4 files changed, 3 insertions(+), 18 deletions(-)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-richedit-Removed-redundant-editor-height-variabl.diff.txt

More information about the wine-patches mailing list