[PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

Nick Burns adger44 at hotmail.com
Mon Dec 22 08:23:53 CST 2008

This is a resubmission of my previous (previous) patch
I fixed the issue Stefan found
1 - readpixels was broken in both paths (not just the pbo path)

This is my last gfx fix for SHOGO
The readpixels call was putting data into the wrong place (fixed with pixelstore)
And the y-flip code was flipping the wrong data as well (set the bottom row to the bottom row and not the height'th row)

The code handled fullscreen 2d blits (or blts without any colorkey masking) correctly
However sub-blits had issues
    1 - readpixels read into the wrong place
    2 - the y-flip code would move around the uninited data (from the readpixels) and it read from the wrong place
    3 - After 1 and 2 the backing is corrupt and the blt code had no chance...

This patch fixes 1 and 2 -- letting the blt code shine
This can be seen in the SHOGO menu (now not corrupt! with or without pbo!)

    Fix glReadPixels call from read_from_framebuffer    
    Fix the call to readpixels so that 2d blts end up in the right place and get flipped correctly

 - Nick
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0007-Fix-glReadPixels-call-from-read_from_framebuffer.patch
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20081222/f549364c/attachment-0001.txt 

More information about the wine-patches mailing list